Support COOP same-origin-allow-popups #7408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vickiez
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz,
konstantin-msft,
lalimasharda and
shylasummers
as code owners
david-risney
reviewed
Nov 7, 2024
david-risney
reviewed
Nov 7, 2024
david-risney
reviewed
Nov 7, 2024
| @@ -58,6 +58,7 @@ export type PopupParams = { | |||
| export class PopupClient extends StandardInteractionClient { | |||
| private currentWindow: Window | undefined; | |||
| protected nativeStorage: BrowserCacheManager; | |||
| private authChannel: BroadcastChannel; | |||
There was a problem hiding this comment.
Seems like BroadcastChannel is well supported (https://caniuse.com/broadcastchannel) although not sure if this PopupClient.ts code needs to run in super old contexts. If so, they might want to check if BroadcastChannel doesn't exist and fallback to their URI change polling code. But if this is demo fix for them then probably none of that is necessary anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of using BroadcastChannel to communicate between the same origin across browsing contexts, enabling popup auth flow when the app has a cross-origin opener policy of "same-origin-allow-popups"
*The final solution should ensure the correct InteractionType is used for redirects vs popups and should handle the case where popup window is closed by user