Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the native account retrieval logic by adding validation for empty or invalid account filters. When no login hint or SID is provided, the code now properly falls back to using the active account's native account ID instead of attempting to filter with invalid criteria.
Key changes:
- Added validation in
CacheManager.getAccountInfoFilteredByto detect and handle empty/invalid account filters - Removed redundant filter validation from
AccountManager.getAccountsince it's now handled at the cache layer - Added test coverage for the new validation logic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/msal-common/src/cache/CacheManager.ts | Added validation to return null and log a warning when account filter is empty or contains only falsy values |
| lib/msal-common/test/cache/CacheManager.spec.ts | Added test case verifying null is returned when filter has empty string values |
| lib/msal-browser/src/cache/AccountManager.ts | Removed duplicate empty filter check and simplified logging |
| lib/msal-browser/test/cache/BrowserCacheManager.spec.ts | Added test case verifying null is returned when filter has undefined values |
Co-authored-by: Copilot <[email protected]>
…AD/microsoft-authentication-library-for-js into v5_bugfix_getNativeAccount
Contributor
|
This looks like it changes the behavior of the API, is this intended? |
Contributor
|
Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft. |
microsoft-github-policy-service
bot
added
the
Needs: Attention 👋
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v5 PR for the getNativeAccountId bug fix (#7960)