[V5] Updates samples to match the deprecation of proxyUrl and customAgentOptions in msal-node's HttpClient
#8139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
previously approved these changes
Nov 11, 2025
bgavrilMS
reviewed
Nov 12, 2025
samples/msal-node-samples/auth-code-distributed-cache/src/AuthProvider.ts
Show resolved
Hide resolved
bgavrilMS
previously approved these changes
Nov 12, 2025
…ive-fetch-samples-updates-v5
…ive-fetch-samples-updates-v5
Robbie-Microsoft
dismissed stale reviews from bgavrilMS and tnorling
The base branch was changed.
bgavrilMS
approved these changes
Nov 14, 2025
tnorling
approved these changes
Nov 14, 2025
Robbie-Microsoft
deleted the
rginsburg/node-native-fetch-samples-updates-v5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the samples to match the deprecation of
proxyUrlandcustomAgentOptionsin msal-node's HttpClient. That parent PR is #8137.The affected sample has been manually tested; Fiddler Everywhere still successfully captures network traffic.