-
Notifications
You must be signed in to change notification settings - Fork 6
Expand Authorization header to support binding certificate for mTLS scenarios #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Authorization header to support binding certificate for mTLS scenarios #209
Conversation
- Add AuthorizationHeaderInformation class with support for authorization header value, mTLS certificate, and additional headers - Add AuthorizationHeaderError class extending OperationError for error handling - Add AuthorizationHeaderResult class wrapping OperationResult with implicit string conversion for backward compatibility - Add comprehensive unit tests covering all functionality and edge cases - Update all PublicAPI.Unshipped.txt files for target frameworks - All 79 tests passing including 18 new authorization header tests Co-authored-by: jmprieur <[email protected]>
|
Is a per-header size limit a concern? JWT size can vary, due to custom claims and by embedding the certificate into the same header we might be putting additional strain on the customizability. We might need to document additional mitigations per server platform in case we embed them together. |
src/Microsoft.Identity.Abstractions/DownstreamApi/AuthorizationHeaderInformation.cs
Outdated
Show resolved
Hide resolved
I don't understand. Which header are your talking about, @MZOLN ? the AuthorizationHeader? how is it different from today?. |
src/Microsoft.Identity.Abstractions/DownstreamApi/AuthorizationHeaderResult.cs
Show resolved
Hide resolved
Co-authored-by: jmprieur <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
src/Microsoft.Identity.Abstractions/DownstreamApi/AuthorizationHeaderInformation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Abstractions/DownstreamApi/AuthorizationHeaderInformation.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jmprieur <[email protected]>
Co-authored-by: jmprieur <[email protected]>
jmprieur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @copilot
src/Microsoft.Identity.Abstractions/DownstreamApi/AuthorizationHeaderInformation.cs
Show resolved
Hide resolved
Co-authored-by: jmprieur <[email protected]>
jmprieur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/Microsoft.Identity.Abstractions/DownstreamApi/AuthorizationHeaderResult.cs
Show resolved
Hide resolved
Co-authored-by: jmprieur <[email protected]>
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.