Skip to content

Add authorization header provider interface to return token with binding certificate #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2025
Merged

Add authorization header provider interface to return token with binding certificate #223

merged 4 commits into from
Oct 28, 2025

Conversation

@cpp11nullptr
Copy link
Contributor

@cpp11nullptr cpp11nullptr commented Oct 22, 2025 •
edited
Loading

Add authorization header provider interface to return token with binding certificate

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

This PR adds a new interface IAuthorizationHeaderBoundProvider with CreateAuthorizationHeaderBound* APIs which return AuthorizationHeaderInformation containing token and bound to the token certificate to be used in mTLS PoP scenarios.

@cpp11nullptr cpp11nullptr changed the title Update create authorization header API to include binding certificate [POC] Update create authorization header API to include binding certificate Oct 22, 2025
@cpp11nullptr cpp11nullptr changed the title [POC] Update create authorization header API to include binding certificate Add create authorization header APIs to return token with binding certificate Oct 24, 2025
@cpp11nullptr cpp11nullptr marked this pull request as ready for review October 24, 2025 19:26
@cpp11nullptr cpp11nullptr requested a review from a team as a code owner October 24, 2025 19:26
jmprieur
jmprieur reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed an alternative

keegan-caruso
keegan-caruso approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question on a comment

@cpp11nullptr cpp11nullptr changed the title Add create authorization header APIs to return token with binding certificate Add authorization header provider interface to return token with binding certificate Oct 28, 2025
@cpp11nullptr cpp11nullptr merged commit 1c15052 into main Oct 28, 2025
5 checks passed
@cpp11nullptr cpp11nullptr deleted the iepoly/update-create-authorization-header-api-to-include-binding-certificate branch October 28, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmprieur jmprieur jmprieur approved these changes

@keegan-caruso keegan-caruso keegan-caruso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpp11nullptr @jmprieur @keegan-caruso