-
Notifications
You must be signed in to change notification settings - Fork 8
Adding client assertion claims #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jmprieur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the tests are incorrect (probably testing a previous attempt)
Aside
There can be cases where the claims in the signed assertion is per request, right @bgavrilMS ? For instance the Fmi path in the case of Agent identies?
What is the scenario for the signed assertions on the app? is it for Ip address etc ?
src/Microsoft.Identity.Abstractions/ApplicationOptions/MicrosoftEntraApplicationOptions.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Identity.Abstractions.Tests/DownstreamApiTests.cs
Outdated
Show resolved
Hide resolved
I am not familiar with |
…ftEntraApplicationOptions.cs Co-authored-by: Jean-Marc Prieur <[email protected]> Signed-off-by: Travis Walker <[email protected]>
…rosoft-identity-abstractions-for-dotnet into trwalke/ClientClaims
|
@trwalke - let's please pause this for a few days. We don't need to ship this the December release of our SDKs. |
Signed-off-by: Jean-Marc Prieur <[email protected]>
The scenario is for sending some custom information from client to eSTS when using a Certificate as a credential. Agentic flows do use federated credentials, so they are not affected. |
Fix for #231
This pull request adds support for specifying client assertion claims in the
MicrosoftEntraApplicationOptionsclass, enabling scenarios where custom claims are needed for client authentication via signed JWTs. The changes ensure that these claims are properly handled during object cloning and are exposed in the public API surface across all target frameworks.MicrosoftEntraApplicationOptions enhancements:
ClientAssertionClaimsof typeIDictionary<string, string>?toMicrosoftEntraApplicationOptions, allowing users to set custom claims for client assertions. This property includes XML documentation explaining its purpose and usage.MicrosoftEntraApplicationOptionsto ensure thatClientAssertionClaimsis copied when cloning an instance.Public API updates:
ClientAssertionClaimsproperty in the public API files for all supported frameworks, making it available to consumers.Testing improvements:
CloneClonesAllPropertiesunit test to verify thatClientAssertionClaimsis correctly cloned and preserved in downstream API options. [1] [2]# {PR title}Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)