Skip to content

Conversation

@cpp11nullptr
Copy link
Contributor

No description provided.

@cpp11nullptr cpp11nullptr requested a review from a team as a code owner December 9, 2025 18:21
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot : I think we need

Microsoft.Identity.Abstractions.IBoundAuthorizationHeaderProvider.CreateBoundAuthorizationHeaderAsync(Microsoft.Identity.Abstractions.DownstreamApiOptions! downstreamApiOptions, System.Security.Claims.ClaimsPrincipal? claimsPrincipal = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<Microsoft.Identity.Abstractions.OperationResult<Microsoft.Identity.Abstractions.AuthorizationHeaderInformation!, Microsoft.Identity.Abstractions.AuthorizationHeaderError!>>! in the PublicAPI.Unshipped.txt.

Could you please confirm and update if that's the case? thanks!

Copy link
Contributor

Copilot AI commented Dec 10, 2025

@jmprieur I've opened a new pull request, #233, to work on those changes. Once the pull request is ready, I'll request review from you.

@jmprieur
Copy link
Contributor

@copilot we also need to update the MicrosoftIdentityAbstractionsVersion default value to the next major version as this PR introduces a breaking change. Maybe you can take it in #233 too?

Copy link
Contributor

Copilot AI commented Dec 10, 2025

@jmprieur I've opened a new pull request, #234, to work on those changes. Once the pull request is ready, I'll request review from you.

….Unshipped.txt (#233)

* Initial plan

* Add CreateBoundAuthorizationHeaderAsync method signature to PublicAPI.Unshipped.txt files

Co-authored-by: jmprieur <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jmprieur <[email protected]>
…ange (#234)

* Initial plan

* Update MicrosoftIdentityAbstractionsVersion to 10.0.0 for breaking change

Co-authored-by: jmprieur <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jmprieur <[email protected]>
Co-authored-by: Jean-Marc Prieur <[email protected]>
@cpp11nullptr cpp11nullptr merged commit cd2be5f into main Dec 10, 2025
5 checks passed
@cpp11nullptr cpp11nullptr deleted the iepoly/rename-bound-authorization-header-interface branch December 10, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants