-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ExtraQP to inject telemetry SDK ID #2973
base: master
Are you sure you want to change the base?
Conversation
src/Microsoft.Identity.Web.DownstreamApi/Microsoft.Identity.Web.DownstreamApi.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand some of the changes.
61af76a
to
82f3f5c
Compare
82f3f5c
to
15a22d1
Compare
5e6c30f
to
c325c02
Compare
This is now ready for review. @neha-bhargava @jennyf19 @jmprieur |
SummarySummary
CoverageMicrosoft.Identity.Web - 63.6%
Microsoft.Identity.Web.Certificate - 41.4%
Microsoft.Identity.Web.Certificateless - 40.1%
Microsoft.Identity.Web.Diagnostics - 39.1%
Microsoft.Identity.Web.DownstreamApi - 15.5%
Microsoft.Identity.Web.MicrosoftGraph - 42%
Microsoft.Identity.Web.Test.Common - 69.3%
Microsoft.Identity.Web.TokenAcquisition - 52.6%
Microsoft.Identity.Web.TokenCache - 80.8%
|
SummarySummary
CoverageMicrosoft.Identity.Web - 63.6%
Microsoft.Identity.Web.Certificate - 41.4%
Microsoft.Identity.Web.Certificateless - 40.1%
Microsoft.Identity.Web.Diagnostics - 39.1%
Microsoft.Identity.Web.DownstreamApi - 15.5%
Microsoft.Identity.Web.MicrosoftGraph - 42%
Microsoft.Identity.Web.Test.Common - 69.3%
Microsoft.Identity.Web.TokenAcquisition - 52.6%
Microsoft.Identity.Web.TokenCache - 80.8%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @bgavrilMS
a701d2e
to
32674df
Compare
SummarySummary
CoverageMicrosoft.Identity.Web - 63.6%
Microsoft.Identity.Web.Certificate - 41.4%
Microsoft.Identity.Web.Certificateless - 40.1%
Microsoft.Identity.Web.Diagnostics - 39.1%
Microsoft.Identity.Web.DownstreamApi - 15.5%
Microsoft.Identity.Web.MicrosoftGraph - 42%
Microsoft.Identity.Web.Test.Common - 69.3%
Microsoft.Identity.Web.TokenAcquisition - 52.6%
Microsoft.Identity.Web.TokenCache - 80.8%
|
@neha-bhargava - can you please have a look at this one ? |
See AzureAD/microsoft-authentication-library-for-dotnet#4864 for details. Goal is to identify zero-touch APIs
DownstreamAPI
. Afaik this is the only zero-touch API.This information will be captured via OTEL and via Http telemetry by MSAL.
Alternatives we can consider:
x-client-brkver
x-telem-last
which is currently out of useMergeOptions
but it does not seem to be called from allCallApi
methods?