Find tcl8 on Fedora-based systems #783
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of tcl 9, tcl8 commands get installed with a suffix, e.g. 'tclsh8'. platform.sh rejects tcl 9 as unsupported, and fails to find tcl 8 when installed with a suffix. Since 'tclsh8' more specifically identifies a tcl version that's definitely supported, look for that first, and then try the generic 'tclsh' as a fallback. Signed-off-by: David Anderson <[email protected]>
|
I believe the check you're referring to is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of tcl 9, tcl8 commands get installed with a suffix, e.g. 'tclsh8'. platform.sh rejects tcl 9 as unsupported, and fails to find tcl 8 when installed with a suffix.
Since 'tclsh8' more specifically identifies a tcl version that's definitely supported, look for that first, and then try the generic 'tclsh' as a fallback.
With this change, I'm able to
make install-srcon Fedora 42. Without it, the build fails partway because platform.mk fails to find a usable tclsh.Possible alternative: support tcl 9? The build fails with a specific "unsupported" error when I have tcl9 installed. I assumed that meant that actual work is required to port to tcl9, but if that check is just a case of "it should work, but we want to verify explicitly before allowing it", I can instead try to do that, if you'd prefer.