Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deepcopy method to SensorDict #130

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Added deepcopy method to SensorDict #130

merged 2 commits into from
Aug 21, 2023

Conversation

danielandresarcones
Copy link
Collaborator

@danielandresarcones danielandresarcones commented Aug 17, 2023 •
edited
Loading

SensorsDict now has deepcopy method for deep copies.

@danielandresarcones danielandresarcones added enhancement New feature or request material Related to implementing the material problem sensor Related to the sensors labels Aug 17, 2023
@danielandresarcones danielandresarcones linked an issue Aug 17, 2023 that may be closed by this pull request
SensorsDict does not allows deep copies #129
Closed
srosenbu
srosenbu requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@srosenbu srosenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small suggestion;)

src/fenicsxconcrete/finite_element_problem/base_material.py Outdated Show resolved Hide resolved
srosenbu
srosenbu approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@srosenbu srosenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ;)

Sorry, I didn't see the changes on friday

@danielandresarcones danielandresarcones merged commit ae72785 into main Aug 21, 2023
6 checks passed
@danielandresarcones danielandresarcones deleted the 129-sensorsdict-does-not-allows-deep-copies branch August 21, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosenbu srosenbu srosenbu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request material Related to implementing the material problem sensor Related to the sensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SensorsDict does not allows deep copies
2 participants
@danielandresarcones @srosenbu