Skip to content

[Koin Project] Regex최적화 #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Koin Project] Regex최적화 #908

wants to merge 1 commit into from

Conversation

jusang3057
Copy link
Contributor

  • 가독성을 위한 Raw String 통일($ -> ${'$'})
  • 단일로 사용중인 [0-9] -> \d로 통일
  • 단일로 사용중인 [^0-9] -> \D로 통일
  • 전화번호 앞자리 010 고정(011 등의 번호는 이제 법적으로 사용 불가능하게 됨에 따라 수정)

Regex 최적화
7c02c7a 
 - 가독성을 위한 Raw String 통일($ -> ${'$'})
 - 단일로 사용중인 [0-9] -> \d로 통일
 - 단일로 사용중인 [^0-9] -> \D로 통일
 - 전화번호 앞자리 010 고정(011 등의 번호는 이제 법적으로 사용 불가능하게 됨에 따라 수정)
@jusang3057 jusang3057 requested a review from a team as a code owner July 22, 2025 01:26
@github-actions github-actions bot requested a review from JaeYoung290 July 22, 2025 01:26
kongwoojin
kongwoojin reviewed Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳이 [0-9] 대신 \d를 쓰는 이유를 모르겠어요
가독성 면에서는 전자가 낫지 않나요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongwoojin kongwoojin kongwoojin left review comments

@JaeYoung290 JaeYoung290 Awaiting requested review from JaeYoung290

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fix Code fix koin project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jusang3057 @kongwoojin