Removing the master and slave terminology#266
Open
bopopescu wants to merge 1 commit intoBD2KGenomics:masterfrom
Open
Removing the master and slave terminology#266bopopescu wants to merge 1 commit intoBD2KGenomics:masterfrom
bopopescu wants to merge 1 commit intoBD2KGenomics:masterfrom
Conversation
hannes-ucsc
requested changes
Jul 27, 2020
Contributor
hannes-ucsc
left a comment
hannes-ucsc
left a comment
There was a problem hiding this comment.
Thank you for this pull request. We'd prefer leader instead of main.
And could you please change the commit title to
Change "master" to "leader" for more inclusive language
| self.option( '--cluster-name', '-c', metavar='NAME', | ||
| help=heredoc( """A name for the new cluster. If absent, the instance ID of | ||
| the master will be used. Cluster names do not need to be unique, but they | ||
| the main will be used. Cluster names do not need to be unique, but they |
Contributor
There was a problem hiding this comment.
Suggested change
| the main will be used. Cluster names do not need to be unique, but they | |
| the leader will be used. Cluster names do not need to be unique, but they |
| used_cluster_ordinals = set( w.cluster_ordinal for w in workers ) | ||
| assert len( used_cluster_ordinals ) == len( workers ) # check for collisions | ||
| assert 0 not in used_cluster_ordinals # master has 0 | ||
| assert 0 not in used_cluster_ordinals # main has 0 |
Contributor
There was a problem hiding this comment.
Suggested change
| assert 0 not in used_cluster_ordinals # main has 0 | |
| assert 0 not in used_cluster_ordinals # leader has 0 |
| class RsyncClusterCommand( RsyncCommandMixin, ApplyClusterCommand ): | ||
| """ | ||
| Run rsync against each node in a cluster. The rsync program will be run against master first, | ||
| Run rsync against each node in a cluster. The rsync program will be run against main first, |
Contributor
There was a problem hiding this comment.
Suggested change
| Run rsync against each node in a cluster. The rsync program will be run against main first, | |
| Run rsync against each node in a cluster. The rsync program will be run against the leader first, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.