Added go-to-definition feature to weidu .d files

[podcherklife]

This PR adds limited go-to-defintion feature for weidu .d files.

Definitions are collected only from open files.
Go-to-definition works only for GOTO and EXTERN weidu commands.

Notes regarding implementation:

Holding clrl causes file to be re-parsed on every cursor move. I did not notice any visible impact on performance even for large files, but you mileage may vary.

I got a bit confused about how to implement a language-specific symbol lookup, and went the most direct way. Suggestions on how to properly improve that are welcome.

Files in src/dparser/* were generated from this grammar: https://gitlab.com/lapdu/lapdu-parser/-/tree/master/src/main/antlr4/imports
They can be generated by build script instead, but that would require java dependency during build which might be undesirable.

[burner1024]

That's cool.
I've been meaning to get to ANTLR4 next, in particular as the road to autoformatting.

Language-specific features I prefer to put into corresponding weidu.ts or fallout.ts files. Or, failing that, route through Galactus

VScode-BGforge-MLS/server/src/galactus.ts

Lines 231 to 233 in 96f48ca

	// the only language with external headers dir
	if (l.id == "fallout-ssl") {
	language = new Language(

But there's been no need for language-specific lookup. I guess you can pass langId to symbolAtPosition and handle the switch there, in common.ts
Doesn't current symbolAtPosition return correct symbol, though?

They can be generated by build script instead, but that would require java dependency during build which might be undesirable.

Yes, will need the generation script. Not necessarily at build time, but need to have a way to regenerate this automatically.
See https://github.com/BGforgeNet/VScode-BGforge-MLS/blob/master/scripts/ie-update.sh for an example. I just checkout upstream repos into ./external and pull data. Kind of horrible, but better than nothing, upstreams don't change often.

Also seems ESlint is plenty angry.

[Copilot]

Pull Request Overview

This PR adds a go-to-definition feature for .d files in the Weidu language support by leveraging a simple ANTLR-based parser to collect definitions from open files and hooking it into the LSP definition handler.

• Introduces a specialized symbol finder for weidu-d in the onDefinition handler.
• Enables definition and udf features for weidu-d in language and Galactus configurations.
• Adds d.ts with ANTLR visitor implementations to collect state definitions and transition targets for go-to-definition.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

File	Description
server/src/server.ts	Imports and invokes a custom symbol finder for the weidu-d language in the definition hook
server/src/language.ts	Registers loadFileData under the weidu-d language ID
server/src/galactus.ts	Enables definition and udf features for weidu-d
server/src/d.ts	Implements ANTLR-based parsing, symbol collection, and state-definition logic

Comments suppressed due to low confidence (2)

server/src/server.ts:20

• [nitpick] The alias findTransitionAtPosition may be misleading since it wraps findSymbolAtPosition. Consider using a name that reflects it finds symbols (e.g., findSymbolAtPosition) for consistency.

import { findSymbolAtPosition as findTransitionAtPosition } from "./d";

server/src/d.ts:68

• [nitpick] There's a typo in the class name ErroResistantVisitor. Consider renaming it to ErrorResistantVisitor for correct spelling and clarity.

abstract class DlgAwareErroResistantVisitor<T> extends AbstractParseTreeVisitor<T> implements DParserVisitor<T> {

[Copilot]

Use strict equality (===) instead of loose equality (==) when comparing langId to avoid unintended type coercion.

Suggested change

	if (langId == "weidu-d") {
	if (langId === "weidu-d") {

[Copilot]

The else if condition lacks grouping, so str[0] == '"' or str[0] == '%' will be evaluated even if str.length is 0. Wrap the OR clauses in parentheses: else if (str.length > 0 && (str[0] == '~' || str[0] == '"' || str[0] == '%')).

Suggested change

	} else if (str.length > 0 && str[0] == '~' || str[0] == "\"" || str[0] == '%') {
	} else if (str.length > 0 && (str[0] == '~' || str[0] == "\"" || str[0] == '%')) {