667 restructure element creation #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into 667-restructure-element-creation
…. Add groundfloor
…' into 667-restructure-element-creation
…' into 667-restructure-element-creation
…' into 667-restructure-element-creation # Conflicts: # bim2sim/tasks/bps/disaggr_creation.py
…ssigned to outer wall now).
…' into 667-restructure-element-creation
veronikarichter
requested changes
Jul 8, 2024
Co-authored-by: Veronika Richter <[email protected]>
veronikarichter
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings a cleaned structure of how to handle elements. Everything is stored inside the
elementsdict and we have no moretz_elements,space_boundariesetc. lists that point to the differentelements.Also the layer and material enrichment is now cleaner, but we had to remove the LOD.full option (which inriches only partly the existing IFC information for now). We will reimplement this again in another PR, see #676