Skip to content

uniform sim_settings for space boundaries #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaJansenGit wants to merge 6 commits into
base: development
Choose a base branch
from
Open

uniform sim_settings for space boundaries #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
150caab
uniform sim_settings for space boundaries
DaJansenGit Jan 6, 2025
6f4d970
Merge branch 'development' into 777-adjust-sim-settings-for-space-bou…
DaJansenGit Jan 29, 2025
3cc5cb5
adjust teaser regression test to new default sim_settings
DaJansenGit May 15, 2025
d8569d2
Merge remote-tracking branch 'origin/777-adjust-sim-settings-for-spac…
DaJansenGit May 15, 2025
71ff4ac
adjust teaser regression test to new default sim_settings
DaJansenGit May 15, 2025
e13525a
Merge branch 'refs/heads/development' into 777-adjust-sim-settings-fo…
DaJansenGit May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions bim2sim/plugins/PluginEnergyPlus/bim2sim_energyplus/sim_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,17 +140,6 @@ class EnergyPlusSimSettings(BuildingSimSettings):
multiple_choice=True,
for_frontend=True
)
correct_space_boundaries = BooleanSetting(
default=True,
description='Apply geometric correction to space boundaries.',
for_frontend=True
)
close_space_boundary_gaps = BooleanSetting(
default=True,
description='Close gaps in the set of space boundaries by adding '
'additional 2b space boundaries.',
for_frontend=True
)
add_natural_ventilation = BooleanSetting(
default=True,
description='Add natural ventilation to the building. Natural '
Expand Down
2 changes: 1 addition & 1 deletion bim2sim/plugins/PluginTEASER/bim2sim_teaser/sim_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,4 @@ class TEASERSimSettings(BuildingSimSettings):
'prepare_regression_tests.py script.',
for_frontend=False,
mandatory=False
)
)
2 changes: 2 additions & 0 deletions bim2sim/plugins/PluginTEASER/test/regression/test_teaser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ def test_run_kitfzkhaus(self):
project.sim_settings.zoning_criteria = (
ZoningCriteria.combined_single_zone)
project.sim_settings.ahu_tz_overwrite = False
project.sim_settings.close_space_boundary_gaps = False
project.sim_settings.correct_space_boundaries = False
answers = ()
handler = DebugDecisionHandler(answers)
for decision, answer in handler.decision_answer_mapping(project.run()):
Expand Down
21 changes: 2 additions & 19 deletions bim2sim/sim_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,23 +600,6 @@ def check_mandatory(self):
for_frontend=True
)

add_space_boundaries = BooleanSetting(
default=False,
description='Add space boundaries. Only required for building '
'performance simulation and co-simulations.',
for_frontend=True
)
correct_space_boundaries = BooleanSetting(
default=False,
description='Apply geometric correction to space boundaries.',
for_frontend=True
)
close_space_boundary_gaps = BooleanSetting(
default=False,
description='Close gaps in the set of space boundaries by adding '
'additional 2b space boundaries.',
for_frontend=True
)
stories_to_load_guids = GuidListSetting(
default=[],
description='List of IFC GUIDs for the specific stories that should '
Expand Down Expand Up @@ -1103,7 +1086,7 @@ def __init__(self):
for_frontend=True
)
correct_space_boundaries = BooleanSetting(
default=False,
default=True,
description='Apply geometric correction to space boundaries.',
for_frontend=True
)
Expand All @@ -1125,7 +1108,7 @@ def __init__(self):
for_frontend=True
)
close_space_boundary_gaps = BooleanSetting(
default=False,
default=True,
description='Close gaps in the set of space boundaries by adding '
'additional 2b space boundaries.',
for_frontend=True
Expand Down