170 ifc check via ids

.gitlab-ci.yml

@@ -238,6 +238,18 @@ PluginOpenFOAM:py3.11:
   variables:
     plugin: "PluginOpenFOAM"
 
+PluginIFCCheck:py3.10:
+  <<: *test_template_plugin_integration
+  image: $CI_REGISTRY/bim2sim:py3.10-occ7.9.0
+  variables:
+    plugin: "PluginIFCCheck"
+
+PluginIFCCheck:py3.11:
+  <<: *test_template_plugin_integration
+  image: $CI_REGISTRY/bim2sim:py3.11-occ7.9.0
+  variables:
+    plugin: "PluginIFCCheck"
+
 # Regression tests
 PluginTEASER_reg:py3.10:
   <<: *test_template_plugin_regression
@@ -287,3 +299,14 @@ PluginOpenFOAM_reg:py3.11:
   variables:
     plugin: "PluginOpenFOAM"
 
+PluginIFCCheck:py3.10:
+  <<: *test_template_plugin_regression
+  image: $CI_REGISTRY/bim2sim:py3.10-occ7.9.0
+  variables:
+    plugin: "PluginIFCCheck"
+
+PluginIFCCheck:py3.11:
+  <<: *test_template_plugin_regression
+  image: $CI_REGISTRY/bim2sim:py3.11-occ7.9.0
+  variables:
+    plugin: "PluginIFCCheck"

.gitmodules

@@ -1,7 +1,7 @@
 [submodule "test/resources"]
 	path = test/resources
 	url = https://github.com/BIM2SIM/bim2sim-test-resources.git
-    branch = main
+    branch = 15-update_test_resources_ifccheck
 [submodule "butterfly"]
 	path = butterfly
 	url = https://github.com/BIM2SIM/butterfly.git

bim2sim/assets/templates/check_ifc/guid_template

@@ -0,0 +1,81 @@
+<style type="text/css">
+    .tg  {border-collapse:collapse;border-color:#ccc;border-spacing:0;}
+    .tg td{background-color:#fff;border-color:#ccc;border-style:solid;
+        border-width:1px;color:#333;
+        font-family:Arial, sans-serif;font-size:14px;overflow:hidden;
+        padding:10px 6px;word-break:normal;}
+    .tg th{background-color:#f0f0f0;border-color:#ccc;border-style:solid;
+        border-width:1px;color:#333;
+        font-family:Arial, sans-serif;font-size:14px;font-weight:normal;
+        overflow:hidden;padding:10px 6px;word-break:normal;}
+    .tg .tg-c3ow{border-color:inherit;text-align:center;vertical-align:top}
+    .tg .tg-fymr{border-color:inherit;font-weight:bold;text-align:left;
+        vertical-align:top}
+    .tg .tg-7btt{border-color:inherit;font-weight:bold;text-align:center;
+        vertical-align:top}
+    .tg .tg-dvpl{border-color:inherit;text-align:right;vertical-align:top}
+    .tg .tg-0pky{border-color:inherit;text-align:left;vertical-align:top}
+</style>
+<h2>Overview</h2>
+<table class="tg">
+    <thead>
+        <tr>
+            <th colspan=2 class="tg-7btt">GUID error Summary</th>
+        </tr>
+    </thead>
+    <tbody>
+        <tr>
+            <th colspan=2 class="tg-7btt"><a href="#NonUniqueGUID">Non-Unique GUID</a>
+            </th>
+        </tr>
+        <tr>
+            <td class="tg-fymr">Total non-unique GUIDs:</td>
+            <td class="tg-dvpl"> ${len(double_guids)}</td>
+        </tr>
+
+        <tr>
+            <th colspan=2 class="tg-7btt"><a href="#EmptyGUID">Empty GUID</a>
+            </th>
+        </tr>
+        <tr>
+            <td class="tg-fymr">Total Empty GUIDs:</td>
+            <td class="tg-dvpl"> ${len(empty_guids)}</td>
+        </tr>
+    </tbody>
+</table><br>
+
+<h2 id="NonUniqueGUID">Non-Unique GUIDs</h2>
+<table class="tg">
+    <thead>
+        <tr>
+            <th class="tg-1wig">GUID</th>
+            <th class="tg-1wig">Name</th>
+        </tr>
+    </thead>
+    %for guid, values in double_guids.items():
+        <tr>
+            <td class="tg-1wig">${guid}</td>
+            <td class="tg-1wig">${values.Name}</td>
+        </tr>
+    %endfor
+    </tbody>
+</table><br>
+
+<h2 id="EmptyGUID">Empty GUIDs</h2>
+<table class="tg">
+    <thead>
+        <tr>
+            <th class="tg-1wig">Generated Key (bim2sim)</th>
+            <th class="tg-1wig">Name</th>
+            <th class="tg-1wig">GlobalID</th>
+        </tr>
+    </thead>
+    %for key, values in empty_guids.items():
+        <tr>
+            <td class="tg-1wig">${key}</td>
+            <td class="tg-1wig">${values.Name}</td>
+            <td class="tg-1wig">${values.GlobalId}</td>
+        </tr>
+    %endfor
+    </tbody>
+</table><br>

bim2sim/assets/templates/check_ifc/inst_template

@@ -56,8 +56,7 @@
             ${task.sub_inst_cls}</a></th>
         </tr>
         <tr>
-            <td class="tg-fymr">Total ${task.sub_inst_cls} with errors:
-            &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</th>
+            <td class="tg-fymr">Total ${task.sub_inst_cls} with errors:</th>
             <td class="tg-dvpl">
             ${len(task.error_summary_sub_inst)}/${len(task.sub_inst)}</th>
         </tr>
@@ -110,4 +109,4 @@
         %endfor
     </tbody>
 </table><br>
-%endfor
+%endfor

bim2sim/assets/templates/check_ifc/summary_template

@@ -32,20 +32,20 @@
         <tr>
             <td class="tg-dvpl">Total IFCProduct with errors:</td>
             <td class="tg-dvpl">
-            ${len(task.error_summary_inst)}/${len(task.elements)}</th>
+            ${len(task.error_summary_inst)}/${len(task.elements)}</td>
         </tr>
         <tr>
             <td class="tg-dvpl">Total errors in IFCProducts:</td>
-            <td class="tg-dvpl">${sum(summary_inst['per_error'].values())}</th>
+            <td class="tg-dvpl">${sum(summary_inst['per_error'].values())}</td>
         </tr>
         <tr>
             <td class="tg-dvpl">Total ${task.sub_inst_cls} with errors:</td>
             <td class="tg-dvpl">
-            ${len(task.error_summary_sub_inst)}/${len(task.sub_inst)}</th>
+            ${len(task.error_summary_sub_inst)}/${len(task.sub_inst)}</td>
         </tr>
         <tr>
             <td class="tg-dvpl">Total errors in ${task.sub_inst_cls}:</td>
-            <td class="tg-dvpl">${sum(summary_sbs['per_error'].values())}</th>
+            <td class="tg-dvpl">${sum(summary_sbs['per_error'].values())}</td>
         </tr>
         <tr>
             <th  colspan=2 class="tg-7btt"><a href=
@@ -56,11 +56,11 @@
         <tr>
             <td class="tg-dvpl">Total IFCProduct with missing properties:</td>
             <td class="tg-dvpl">
-            ${len(task.error_summary_prop)}/${len(task.elements)}</th>
+            ${len(task.error_summary_prop)}/${len(task.elements)}</td>
         </tr>
         <tr>
             <td class="tg-dvpl">Total missing properties in IFCProducts:</td>
-            <td class="tg-dvpl">${sum(summary_props['per_error'].values())}</th>
+            <td class="tg-dvpl">${sum(summary_props['per_error'].values())}</td>
         </tr>
     </tbody>
-</table>
+</table>

bim2sim/assets/templates/check_ifc/summary_template_extend

@@ -0,0 +1,100 @@
+<style type="text/css">
+    .tg  {border-collapse:collapse;border-color:#ccc;border-spacing:0;}
+    .tg td{background-color:#fff;border-color:#ccc;border-style:solid;
+        border-width:1px;color:#333;
+        font-family:Arial, sans-serif;font-size:14px;overflow:hidden;
+        padding:10px 6px;word-break:normal;}
+    .tg th{background-color:#f0f0f0;border-color:#ccc;border-style:solid;
+        border-width:1px;color:#333;
+        font-family:Arial, sans-serif;font-size:14px;font-weight:normal;
+        overflow:hidden;padding:10px 6px;word-break:normal;}
+    .tg .tg-c3ow{border-color:inherit;text-align:center;vertical-align:top}
+    .tg .tg-fymr{border-color:inherit;font-weight:bold;text-align:left;
+        vertical-align:top}
+    .tg .tg-7btt{border-color:inherit;font-weight:bold;text-align:center;
+        vertical-align:top}
+    .tg .tg-dvpl{border-color:inherit;text-align:right;vertical-align:top}
+    .tg .tg-0pky{border-color:inherit;text-align:left;vertical-align:top}
+</style>
+
+<table class="tg">
+    <thead>
+        <tr>
+            <th  colspan=2 class="tg-7btt">${plugin_name} Error Summary</th>
+        </tr>
+    </thead>
+    <tbody>
+        <tr>
+            <th colspan=2 class="tg-7btt">
+            <a>IFC Version</a>
+            </th>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">IFC Version:</td>
+            <td class="tg-dvpl"> ${ifc_version}</td>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Version error:</td>
+            <td class="tg-dvpl"> ${version_error}</td>
+        </tr>
+        <tr>
+            <th colspan=2 class="tg-7btt">
+            <a href="${base_name}_error_summary_guid.html">GUID general</a>
+            </th>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Unique GUID:</td>
+            <td class="tg-dvpl"> ${all_guids_unique}</td>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Total non-unique GUIDs:</td>
+            <td class="tg-dvpl"> ${len(double_guids)}</td>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Empty GUID:</td>
+            <td class="tg-dvpl"> ${all_guids_filled}</td>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Total Empty GUIDs:</td>
+            <td class="tg-dvpl"> ${len(empty_guids)}</td>
+        </tr>
+        <tr>
+            <th colspan=2 class="tg-7btt">
+            <a href="${base_name}_error_summary_inst.html">Errors in IFC</a>
+            </th>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Total IFCProduct with errors:</td>
+            <td class="tg-dvpl">
+            ${len(task.error_summary_inst)}/${len(task.elements)}</td>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Total errors in IFCProducts:</td>
+            <td class="tg-dvpl">${sum(summary_inst['per_error'].values())}</td>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Total ${task.sub_inst_cls} with errors:</td>
+            <td class="tg-dvpl">
+            ${len(task.error_summary_sub_inst)}/${len(task.sub_inst)}</td>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Total errors in ${task.sub_inst_cls}:</td>
+            <td class="tg-dvpl">${sum(summary_sbs['per_error'].values())}</td>
+        </tr>
+        <tr>
+            <th  colspan=2 class="tg-7btt"><a href=
+                "${base_name}_error_summary_prop.html">Missing Attributes for
+                ${plugin_name}</a>
+            </th>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Total IFCProduct with missing properties:</td>
+            <td class="tg-dvpl">
+            ${len(task.error_summary_prop)}/${len(task.elements)}</td>
+        </tr>
+        <tr>
+            <td class="tg-dvpl">Total missing properties in IFCProducts:</td>
+            <td class="tg-dvpl">${sum(summary_props['per_error'].values())}</td>
+        </tr>
+    </tbody>
+</table>

bim2sim/elements/base_elements.py

@@ -450,7 +450,7 @@ def __repr__(self):
     def __str__(self):
         return "%s" % self.__class__.__name__
 
-
+# TODO remove one of both classes RelationBased (see above)
 class RelationBased(IFCBased):
 
     pass

bim2sim/plugins/PluginIFCCheck/bim2sim_ifccheck/__init__.py

@@ -0,0 +1,22 @@
+"""Template plugin for bim2sim
+
+Holds a plugin with only base tasks mostly for demonstration.
+"""
+from bim2sim.plugins import Plugin
+from bim2sim.tasks import common, bps
+from bim2sim.sim_settings import BuildingSimSettings
+from bim2sim.plugins.PluginIFCCheck.bim2sim_ifccheck.sim_settings import \
+    CheckIFCSimSettings
+
+class PluginIFCCheck(Plugin):
+    name = 'IFCCheck'
+    sim_settings = CheckIFCSimSettings
+    default_tasks = [
+        common.LoadIFC,
+        common.CheckIfcIds,
+        # common.CreateElementsOnIfcTypes,
+        # bps.CreateSpaceBoundaries,
+        # bps.EnrichUseConditions,
+        # common.CreateRelations,
+        # common.Weather,
+    ]