Add support for rkyv #356
Open
Add support for rkyv #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monoid
reviewed
Oct 21, 2023
|
|
||
| #[cfg(feature = "rkyv")] | ||
| impl Eq for ArchivedHash {} | ||
|
|
||
| impl fmt::Display for Hash { |
There was a problem hiding this comment.
Shouldn't ArchivedHash implement Display and Debug too? Also, Hash derives std::hash::Hash. Might be useful as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rkyv is a zero copy serialization framework. I use it in a lot of personal projects, and it would be really useful to have support for serializing to rkyv built in, seeing as you do something similar for serde. If this pull request is unwelcome, please let me know and I'll close this.