-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reset #212
Add reset #212
Conversation
This PR changes how measurements are handled in the qasm decoding. It seems that there is a leakage between the mid-circuit measurement PR and the add-reset PR. This makes it hard to review this on its own, with a lot of potential for intermediate issues. You either need to fully decouple them or merge them completely before I can do a proper review. |
I merged all the changes (add reset, MMR and MMR partition) to this PR. Could you only review this PR? Maybe I can just close the other two PRs (MMR and MMR partition)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Shor26_MMR.qasm
file you have the following line multiple times:
measure q;
This is not proper qasm, why does it compile, and what does it mean?
Additionally, it would be nice if you have more diverse reset statements besides just reset q
in both qasm files added.
add qasm support and test files for reset.