Fix identity rebase #222
Merged
Fix identity rebase #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtweiden
reviewed
Feb 15, 2024
There was a problem hiding this comment.
LGTM. Maybe it's worth adding @jagandecapri's code in #217 as a test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217 by 1) passing synthesis epsilon to the rebasing passes in the standard compilation workflow and 2) detecting identity rebasing and handling it specially.
It seems like our standard numerical instantiation pipelines had particular difficulty solving for the identity in the specific CRY case listed in #217.