-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding sub_state function to StateVector #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for continuing to improve BQSKit and add features. This looks good, a couple of small changes are requested. Please, also add a test or two.
] | ||
included_perm = list(location) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two empty lines
def get_sub_state(self, location: CircuitLocationLike) -> StateVector: | ||
""" | ||
Return the StateVector corresponding to the specified location | ||
in the Circuit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop the "in the Circuit" and make this one line. I am also curious how does renormalization happen? Can you provide either more detail about what this does mathematically, provide a reference, or add an example (or two)? Ideally, all of the above.
This function returns a normalized state vector over a sub-selection of qudits in the Circuit.