Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix NotRan typo #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix NotRan typo #62

wants to merge 1 commit into from

Conversation

yhzhu99
Copy link

@yhzhu99 yhzhu99 commented Oct 30, 2021

这里曾经也经过了改动:NotRunned -> NotRan,即认为此处的标识是 not+动词过去式的形式。

我查阅了相关英文语法,我认为此处应当是 It is not done. (not+动词过去分词) 的形式,使用到的是被动语态。即我认为应将其修改为run的过去分词形式run,即NotRun。

举例:

  • It is done. (语法正确)
  • It is not done. (语法正确)
  • It is did. (语法错误)

参考:被动语态怎么用? 主语+be动词+及物动词过去分词+(by+动作发出者)

@lynzrand
Copy link
Member

@TualatinX 你们就不能在面对 Breaking API change 的时候稳重点吗.jpg

@lynzrand
Copy link
Member

总之先记下来了,因为是 breaking change 所以至少要推到 0.6.0 的时候再发布。

@lynzrand lynzrand added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants