Skip to content

Commit

Permalink
Change back offset in BinaryDict to size_t, because "size_t" on MSVC …
Browse files Browse the repository at this point in the history
…x64 is unsigned long long.
  • Loading branch information
BYVoid committed Jul 27, 2024
1 parent f34b3bd commit 641bfe9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
15 changes: 8 additions & 7 deletions src/BinaryDict.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,12 @@ void BinaryDict::SerializeToFile(FILE* fp) const {
}

BinaryDictPtr BinaryDict::NewFromFile(FILE* fp) {
long offsetBound, savedOffset;
savedOffset = ftell(fp);
long savedOffset = ftell(fp);
fseek(fp, 0L, SEEK_END);
offsetBound = ftell(fp) - savedOffset;
long offsetBoundLong = ftell(fp) - savedOffset;
fseek(fp, savedOffset, SEEK_SET);
assert(offsetBoundLong >= 0);
size_t offsetBound = static_cast<size_t>(offsetBoundLong);

BinaryDictPtr dict(new BinaryDict(LexiconPtr(new Lexicon)));

Expand Down Expand Up @@ -117,17 +118,17 @@ BinaryDictPtr BinaryDict::NewFromFile(FILE* fp) {
throw InvalidFormat("Invalid OpenCC binary dictionary (numValues)");
}
// Key offset
long keyOffset;
unitsRead = fread(&keyOffset, sizeof(long), 1, fp);
size_t keyOffset;
unitsRead = fread(&keyOffset, sizeof(size_t), 1, fp);
if (unitsRead != 1 || keyOffset >= offsetBound) {
throw InvalidFormat("Invalid OpenCC binary dictionary (keyOffset)");
}
std::string key = dict->keyBuffer.c_str() + keyOffset;
// Value offset
std::vector<std::string> values;
for (size_t j = 0; j < numValues; j++) {
long valueOffset;
unitsRead = fread(&valueOffset, sizeof(long), 1, fp);
size_t valueOffset;
unitsRead = fread(&valueOffset, sizeof(size_t), 1, fp);
if (unitsRead != 1 || valueOffset >= offsetBound) {
throw InvalidFormat("Invalid OpenCC binary dictionary (valueOffset)");
}
Expand Down
2 changes: 1 addition & 1 deletion src/PhraseExtract.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class PhraseExtract::DictType {
marisa::Agent agent;
agent.set_query(key.CString(), key.ByteLength());
if (marisa_trie.lookup(agent)) {
int item_id = marisa_id_item_map[agent.key().id()];
size_t item_id = marisa_id_item_map[agent.key().id()];
return items[item_id].second;
}

Expand Down

0 comments on commit 641bfe9

Please sign in to comment.