-
Notifications
You must be signed in to change notification settings - Fork 103
feat comfyui connector and fix framesync null guard #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hulibruce
merged 20 commits into
BabitMF:master
from
ischencheng:mr/feat-comfyui-connector-and-fix-framesync-null-guard
Oct 28, 2025
Merged
feat comfyui connector and fix framesync null guard #207
hulibruce
merged 20 commits into
BabitMF:master
from
ischencheng:mr/feat-comfyui-connector-and-fix-framesync-null-guard
Oct 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfeiwong
reviewed
Oct 2, 2025
hulibruce
reviewed
Oct 26, 2025
bmf/demo/comfyui_intergration/example_input/extra_data_t2i.json
Outdated
Show resolved
Hide resolved
hulibruce
approved these changes
Oct 27, 2025
Collaborator
hulibruce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job! Thanks for the contribution.
Collaborator
|
@ischencheng cloud you please rebase the latest code in master branch? It might fix the CI issue we encountered. |
…es now properly send an EOF signal, and processing nodes wait for all inputs to complete before propagating EOF. This resolves a race condition that was causing the BMF engine to crash.
…cense issues & [feature] add support for api nodes
2ae22d5 to
0a0a2b5
Compare
Contributor
Author
|
@hulibruce Sure—I rebased, and the CI issue is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a ComfyUI-to-BMF connector that runs ComfyUI graphs on the BMF engine without bundling GPL3.0 code.
Fixes a crash in FrameSync input manager when inputs arrive at different timestamps (mixed-rate/mixed-type flows).
Part 1 — Feature: ComfyUI Connector
What
Runtime integration that converts a ComfyUI prompt graph into a BMF GraphConfig and executes it in-process.
How
Why
Part 2 — Bugfix: FrameSync crash under mixed timestamps
Fix in this MR:
Limitations & follow-ups:
Reproducer (why it used to crash)