Bad3r:feat/db #184
Open
Bad3r:feat/db #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad3r
force-pushed
the
master
branch
4 times, most recently
from
9a2e078
to
458ac81
Compare
that display all nodes for the current property. Property pages now behave like classes and display a table instead of blocks. Also update linter to include objects ns
hard in table. Also display date-picker for empty :date :many to allow for more input
table feature will grow with time and could benefit from its own ns
- Graphs with description page failed to import - Graphs that had a page with a built-in class name mangled the block types. Reverted fix for logseq/db-test#17 - Also updated test for datom count as some parser changes were made last week to alter it
Add tests for recent db ident fixes. Add check that backup keyword is valid edn. Also generate correct keyword for cases like logseq/db-test#4 as catch should be relied only for unexpected cases
Removed test as no error handling is needed for ident generation. Also removed all related downstream uses of catch for db-ident/create-db-ident-from-name that are no longer needed
Linters are read only by default. Lang lint can be fixed by passing `--fix`. We don't want CI or inexperienced contributors fixing files accidentally. Also move deps to bb.edn as putting them inline leads to quirky/buggy tasks listing and autocompleting as they pause when fetching an inlined dep
Also important to keep db graphs decoupled from file specific :block/name. Made sure that related fix in logseq/db-test#9 still works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.