Skip to content

Conversation

@louh
Copy link
Member

@louh louh commented Nov 28, 2024

People on this page can now have links to a personal website, or to Bluesky and Mastodon profiles.

Directory:

Screenshot 2024-11-28 at 1 44 02 PM

Modal:

Screenshot 2024-11-28 at 1 44 07 PM

Additional changes

  • Fix an issue where a missing Twitter handle will appear in the modal linking to an @null account.
  • Implemented react-icons (link) as opposed to generating a new icon font through IcoMoon, which doesn't even have Bluesky on there. This meant building out the <Icon> component with workarounds.
  • When generating links, fix the rel attribute to properly use the noopener noreferrer values. (It was previously attached to target in the people directory, and completely missing in the modal.) I've removed nofollow because these links should make sense for SEO purposes.
  • Updated my own personal bio which contained a lot of out-of-date and inaccurate information.

@louh louh requested a review from slifty November 28, 2024 18:50
Copy link
Member

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!

Thanks lou :D

@louh louh merged commit 239d210 into main Nov 28, 2024
1 check passed
@louh louh deleted the louh/add-more-contact-fields branch November 28, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants