-
Notifications
You must be signed in to change notification settings - Fork 10
Gardening #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Gardening #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, this:
```
5:1 warning Anonymous arrow functions cause Fast Refresh to not preserve local component state.
Please add a name to your function, for example:
Before:
export default () => {}
After:
const Named = () => {}
export default Named;
no-anonymous-exports-page-templates
✖ 1 problem (0 errors, 1 warning)
```
react/jsx-props-no-spreading: We spread props, a lot. It very often improperly adds attributes to DOM elements when it shouldn't, so I get why this rule exists. For now the strategy is to refactor spreading to NOT pass those attributes to DOM (see console messages for warnings), but not completely remove prop spreading. react/require-default-props: Default props are being removed from function components in the future, which throws warnings. So if we don't use default props anymore, then stop warning us when we don't have them.
slifty
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Lots of updates. I tried to keep them pretty contained into individual commits except for the second-to-last one where I was just dumping all of the edits into a large cleanup commit.
Basic rundown of stuff:
defaultPropsin favor of default variables because React was warning this would be deprecated in future (and honestly I feelprop-typesshould be replaced by TypeScript, eventually)<span conditions="[object Object"]>, which ugh)$, e.g.isActive={true}-->$isActive={true}