Skip to content

Small refactors #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Small refactors #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6718f50
refactor(Layout): remove unused variable
louh Dec 3, 2024
cbb1f72
refactor(404): add title to iframe + refactor component
louh Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/ui/partials/Layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,6 @@ class Layout extends Component {
const controls = {
toggleModal: this.toggleMobileMenu
};
const conditions = {
hasMobileMenu
};

return (
<SharedHexContext.Provider
Expand Down
41 changes: 22 additions & 19 deletions src/pages/404.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,27 @@
import React, { Component, Fragment } from "react";
import React from "react";
import styled from "styled-components";

import { Helmet, Layout } from "ui/partials";

export default class ErrorPage extends Component {
constructor(props) {
super(props);
this.state = {};
}
const Iframe = styled.iframe`
overflow: hidden;
border: 0;
`;

render() {
return (
<Fragment>
<Helmet {...this.props} title="Error" />
<Layout {...this.props}>
<h1>You'd think there would be something more interesting here.</h1>
<iframe width="1" height="1" scrolling="no" frameborder="no" allow="autoplay" src="https://w.soundcloud.com/player/?url=https%3A//api.soundcloud.com/tracks/348238181&color=%23ff5500&auto_play=true&hide_related=false&show_comments=true&show_user=true&show_reposts=false&show_teaser=true&visual=true"></iframe>
</Layout>
</Fragment>
);
}
export default function ErrorPage(props) {
return (
<>
<Helmet {...props} title="Error" />
<Layout {...props}>
<h1>You'd think there would be something more interesting here.</h1>
<Iframe
title="Background music"
width="1"
height="1"
allow="autoplay"
src="https://w.soundcloud.com/player/?url=https%3A//api.soundcloud.com/tracks/348238181&color=%23ff5500&auto_play=true&hide_related=false&show_comments=true&show_user=true&show_reposts=false&show_teaser=true&visual=true"
/>
</Layout>
</>
);
}

ErrorPage.propTypes = {};
Loading