Skip to content

Conversation

@louh
Copy link
Member

@louh louh commented Dec 14, 2024

I don't know what the sort by score means since almost everyone has 1 (except for Mark and Annabel). It looks like this causes the published website to sort overlords by first name, then score, but if you're running a local version then all bets are off, it's sorted by random, then score. (With the exception of accomplices, which are sorted by last name.)

I'm proposing to make this consistently sort by first name only across all three categories and removing score from sort order which doesn't seem to serve a purpose (that I know of!)

I kind of like the option of sorting by random, to be honest, but that's not something I think gatsby/graphql can do. (We'd have to tell React to render items at random, which is also fine.)

@louh louh requested a review from slifty December 14, 2024 18:00
@louh louh self-assigned this Dec 14, 2024
@louh louh marked this pull request as ready for review December 14, 2024 18:01
Copy link
Member

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also really like the idea of random, but this is a great in-the-meantime improvement.

@louh louh mentioned this pull request Dec 30, 2024
@louh
Copy link
Member Author

louh commented Dec 30, 2024

Thanks -- merging now, but opening issue #139 for a follow up PR.

@louh louh merged commit 0dbfa81 into main Dec 30, 2024
1 check passed
@louh louh deleted the louh/sort-people branch December 30, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants