Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate .NET Version Selection in build.ps1 #1452

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

mdaneri
Copy link
Contributor

@mdaneri mdaneri commented Nov 13, 2024

Description:
This update improves the build process by dynamically selecting the appropriate .NET versions to deliver binaries, . By automatically excluding unsupported .NET versions, the build.ps1 script now ensures that only maintained versions are targeted for binary generation.

Key Changes:

  • Removing redundant part of code

@Badgerati
Copy link
Owner

I just feel like this is overcomplicating the build process, when all we need to support is simply netstandard2.0, net8.0, and net9.0 (removing net6.0/PS7.2 now they're EOL).

For something that will only be affected once a year, I just feel it's not required. That, and it still requires manual intervention anyway, in the csproj file and workflows.

I'm happy for this to be the net9.0/PS7.5 bump, and net6.0/PS7.2 removal.

@mdaneri
Copy link
Contributor Author

mdaneri commented Nov 13, 2024

Should I roll back to the previous code?
the csproj doesn't require any manual change for the next 3-4 years

@Badgerati
Copy link
Owner

I still feel this is way overengineering something that only takes ~10-20mins once a year to update; plus manually we can properly verify the version bump works, rather than get any nasty surprises.

@mdaneri
Copy link
Contributor Author

mdaneri commented Nov 14, 2024

Ok, I'll drop the eol part
I'm going to use a predetermined array of string

@mdaneri mdaneri changed the title Automate .NET Version Selection in build.ps1 Based on EOL Status Automate .NET Version Selection in build.ps1 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants