-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] BAH-1231 | Add validate PR workflow #63
base: master
Are you sure you want to change the base?
Conversation
7b1a35d
to
502e0f9
Compare
The PR seems fine to me. We just want to run the build with test and test-only, to ensure the build with unit tests passes when a PR is raised. |
@mohan-13 : please review. seems fine to me. |
The setupDB step failed. Please have a look. @NoorShiuli thanks! |
@NoorShiuli Thanks for taking this up. Since the tests would require a database service running pls look into it. You can use service containers in Github Actions. Look at the example here for postgres. You should be able to run mysql as well. |
Also there were some test failures in the repository. Please take a look at this JIRA. https://bahmni.atlassian.net/browse/BAH-1252. It would be great if you can fix the test cases and raise a seperate PR for it. |
@gsluthra @mohan-13 we have updated the validate_pr.yml file. Can you approve this, so that we check if setupDB step is passing? |
Will check this out. |
No description provided.