-
Notifications
You must be signed in to change notification settings - Fork 4
fix: multiple snapshot task triggered #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
emmm,看起来没有什么大的问题,pod由于就绪探针导致的重启也会触发多次snapshotpodtask(但是应该会由于container image不存在导致提前中止?) |
这个可能来不及处理,我看了日志,webhook回调的时候时间间隔非常短(毫秒级别的),可能还没到判断上一个snapshottask的时候下一个事件就来了 |
39c2589
to
ab56813
Compare
ab56813
to
acb58c3
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
acb58c3
to
ac23068
Compare
🥳 |
When a pod is deleted, the Admission Webhook event handle will receive multiple events, so it will trigger the creation of multiple SnapshotTasks, so we need to determine whether there are duplicates