New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of little fixes because I screwed up the clean_files.txt and missed unlinted completions #2294

Merged

seefood merged 13 commits into master from ira/completion-cleanup

Mar 23, 2025

Contributor

seefood commented Mar 22, 2025 •

edited

Loading

cleaning up completions to please the shellcheck gods.

Motivation and Context

directory completion/ was not tested due to a typo, and now it is, and I hope to have fixed the completions.

How Has This Been Tested?

Nada. I am not a user of any of those commandline tools. I am just happy this passes the linters.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
If my change requires a change to the documentation, I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
I have added tests to cover my changes, and all the new and existing tests pass.

seefood added 2 commits

March 22, 2025 19:47


          lots of little fixes because I screwed up the clean_files.txt and mis…

29015c7

…sed unlinted completions.


          one fix that only popped up in the github action(???)

a142385

seefood marked this pull request as ready for review

March 22, 2025 17:55

Contributor Author

seefood commented Mar 22, 2025

Hey @akinomyoga, if you feel like taking a look.
I seem to have mistakenly put completeions/ instead of completion/ in the clean_files, so I just discovered a lot of tests were skipped. hopefully this fixes them all correctly. See if you catch anything I may have broken...

akinomyoga reviewed

View reviewed changes

completion/available/fabric.completion.bash Show resolved Hide resolved

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved

completion/available/fabric.completion.bash Outdated Show resolved Hide resolved

completion/available/fabric.completion.bash Outdated Show resolved Hide resolved

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved

completion/available/rvm.completion.bash Outdated Show resolved Hide resolved

completion/available/vagrant.completion.bash Outdated Show resolved Hide resolved

completion/available/vagrant.completion.bash Outdated Show resolved Hide resolved

akinomyoga mentioned this pull request

Fix formatting #2295

Merged

8 tasks

seefood and others added 6 commits

March 23, 2025 10:28


          Update completion/available/gradle.completion.bash

a93b9fb

Co-authored-by: Koichi Murase <[email protected]>


          Update completion/available/rvm.completion.bash

ba3beaa

Co-authored-by: Koichi Murase <[email protected]>


          lots of suggested fixes from @akinomyoga

bc8264d


          Merge branch 'ira/completion-cleanup' of github.com:Bash-it/bash-it i…

10340b4

…nto ira/completion-cleanup

* 'ira/completion-cleanup' of github.com:Bash-it/bash-it:
  Update completion/available/rvm.completion.bash


          even more fixes from @akinomyoga

9b0134b


          yet more fixes from @akinomyoga

782cce5

seefood requested a review from akinomyoga

March 23, 2025 09:19

seefood self-assigned this

akinomyoga reviewed

View reviewed changes

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved


          Update completion/available/gradle.completion.bash

ddb72e0

Co-authored-by: Koichi Murase <[email protected]>

akinomyoga mentioned this pull request

Help us clean up Bash-it! #1696

Open

akinomyoga reviewed

View reviewed changes

completion/available/fabric.completion.bash Show resolved Hide resolved

completion/available/fabric.completion.bash Show resolved Hide resolved

completion/available/fabric.completion.bash Outdated Show resolved Hide resolved

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved

seefood and others added 3 commits

March 23, 2025 14:46


          Update completion/available/fabric.completion.bash

6f928ad

Co-authored-by: Koichi Murase <[email protected]>


          Update completion/available/fabric.completion.bash

01f30a5

Co-authored-by: Koichi Murase <[email protected]>


          some last readability and logic fixes. hopefully the last round.

ff47ecd

seefood requested a review from akinomyoga

March 23, 2025 13:43

akinomyoga approved these changes

View reviewed changes

Contributor

akinomyoga left a comment

After fixing these, I'm fine with merging.

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved

completion/available/gradle.completion.bash Outdated Show resolved Hide resolved


          Supercalifragelisticexpialidociousable

f1a9268

seefood merged commit 60be5b0 into master

13 checks passed

seefood deleted the ira/completion-cleanup branch

March 23, 2025 14:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet