Fixed rdr rule directive error when a jail has both ipv4 and ipv6 addresses #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resses When a jail has both an ipv4 and ipv6 address, the PF rdr directive needs to differentiate between inet4 and inet6 address families; otherwise, the firewall rule for the ipv6 interface will fail to load on starting the jail: "stdin:3: no translation address with matching address family found. pfctl: Syntax error in config file: pf rules not loaded" This change changes the address family for ipv6 addresses from "inet" to "inet6". Specifications for ipv4 addresses are unchanged.
|
Can you test #765? It has all this and more... |
|
@sinclairday if you can comment with what you tested on the other PR it would help. Especially since you are using dual stack |
I added #765 (comment) detailing my test and results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a jail has both an ipv4 and ipv6 address, the PF
rdrdirective needs to differentiate betweeninetandinet6address families; otherwise, the firewall rule for the ipv6 interface will fail to load on starting the jail:This commit changes the address family for ipv6 addresses from
inettoinet6. Specifications for ipv4 addresses are unchanged.