-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Gas Stations + Fixed Lua #3
Open
BuilderSky
wants to merge
16
commits into
BeamMP:master
Choose a base branch
from
BuilderSky:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI App files deprecated due to simpler use of using input key "E" to refill.
Disabled the breaking of all components if engine is running, will re-enable if requested.
Added 4 gas stations to the Utah map that were missing.
This reverts commit fd21f17.
When the random setting goes off to explode/set fire to the vehicle, it will also set the Fuel Leak Rate to .15 Liters/second.
Added a couple of pumps to the map, as well as changed two pumps from "ev" to "gas".
I added some files with the correct extensions to start working on a UI app for map devs to easily add fuel stations to their maps.
Added some small code to the beginning of two of the files, just starting to get something in the works.
Slightly re-structured code to fit BeamNG UI App creation instructions, available here: https://documentation.beamng.com/modding/ui/app_creation/
Fixed Lua error not allowing fuel stations to show or be usable
At the request of Yellowracer on the BeamNG Mod review section, I have changed the gas cylinder color back to red instead of yellow. (Not sure if you want to re-implement this or not)
I set the X too high, cylinders were in mid-air XD
WCUSA had an update and added fuel stations
Trying to make UI app functional
Starystars67
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to get this handled subject to an in-game test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added gas stations for the new Johnson Valley map, as well as fixed some lua that was not allowing the stations to show on Hirochi and ECUSA.
Also added missing fuel stations on WCUSA due to BeamNG update.
PS. I changed the gas station colors, if that's ok, due to request from Yellowracer on the BeamNG mod review section.