fix: add toast error for unknown errors on login

[ivan-dalmet]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling during social sign-in to display clearer error messages instead of unexpected failures.
  • Enhanced email OTP verification flow with better error messaging and recovery when submission fails.

[coderabbitai]

Walkthrough

Error handling enhancements added to the login page component. Social sign-in mutation and email OTP submission flows now wrapped in try/catch blocks, returning response data on success and displaying toast notifications on failures.

Changes

Cohort / File(s)	Summary
Error handling for authentication flows src/features/auth/page-login.tsx	Added try/catch blocks to social sign-in mutation and email OTP submission flow. Both now return response.data on success and display error toasts (using UNKNOWN_ERROR for unexpected errors) on failure. OTP flow navigates to /login/verify on successful submission.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LoginComponent as Login Component
    participant API as Auth API
    participant Toast as Toast Service

    rect rgb(200, 220, 240)
    Note over LoginComponent,Toast: Social Sign-In Flow (New)
    User->>LoginComponent: Trigger social sign-in
    LoginComponent->>API: Mutation request
    alt Success
        API-->>LoginComponent: response.data
        LoginComponent-->>User: Return response data
    else Error
        API-->>LoginComponent: Error thrown
        LoginComponent->>Toast: Show UNKNOWN_ERROR
        Toast-->>User: Display error toast
    end
    end

    rect rgb(220, 240, 220)
    Note over LoginComponent,Toast: Email OTP Submission Flow (New)
    User->>LoginComponent: Submit OTP
    LoginComponent->>API: OTP verification request
    alt Success
        API-->>LoginComponent: Success response
        LoginComponent->>LoginComponent: Navigate to /login/verify
    else Error or API Error
        API-->>LoginComponent: Error
        LoginComponent->>Toast: Show error/UNKNOWN_ERROR
        Toast-->>User: Display error toast
        LoginComponent->>LoginComponent: Return early
    end
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "fix: add toast error for unknown errors on login" directly aligns with the changeset's main objective. The modifications wrap two login flows (social sign-in and email OTP submission) in try/catch blocks that display toast error notifications for unknown errors, which is precisely what the title describes. The title is specific and concrete, avoiding vague language, and clearly communicates to teammates that this addresses error handling improvements in the login feature by adding user-facing error feedback. The title appropriately captures the core change without unnecessary detail.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/toast-error-login

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11b6773 and 73beb22.

📒 Files selected for processing (1)

• src/features/auth/page-login.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: 🔬 Tests (22)
• GitHub Check: 🔬 Tests (24)

🔇 Additional comments (1)

src/features/auth/page-login.tsx (1)

69-98: LGTM! Email OTP error handling is well-structured.

The error handling implementation is solid:

• Explicit error checking with early return prevents further execution
• Error messages are properly translated using error codes when available
• Fallback to generic UNKNOWN_ERROR for unexpected scenarios
• Clean navigation flow on success

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud