Adds Slapcrafting #12886
Open
Adds Slapcrafting #12886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We must merge this right this instant |
|
While you're here can you fix pouring reagents on pizza bread? Right now it gives the balloon alert but does nothing. |
|
HOLY FUCK WE VANDERLIN NOW!! |
mrmanlikesbt
suggested changes
Jun 15, 2025
Comment on lines
+50
to
+53
| // Gotta instance it to copy the list over. | ||
| recipe = new recipe() | ||
| var/list/type_ingredient_list = recipe.reqs | ||
| qdel(recipe) |
There was a problem hiding this comment.
Suggested change
| // Gotta instance it to copy the list over. | |
| recipe = new recipe() | |
| var/list/type_ingredient_list = recipe.reqs | |
| qdel(recipe) | |
| var/list/type_ingredient_list = initial(recipe.reqs) |
Comment on lines
+553
to
+555
| if(result.len) | ||
| for(var/i in 1 to (length(result) - 1)) | ||
| result[i] += "\n" |
There was a problem hiding this comment.
Github is being silly so I have to do two comments for some reason.
Why not just do result.Join("\n") ?
Suggested change
| if(result.len) | |
| for(var/i in 1 to (length(result) - 1)) | |
| result[i] += "\n" |
|
|
||
| to_chat(src, examine_block(jointext(result, "\n"))) | ||
| SEND_SIGNAL(src, COMSIG_MOB_EXAMINATE, A) | ||
| to_chat(src, examine_block("<span class='infoplain'>[result.Join()]</span>")) |
There was a problem hiding this comment.
Suggested change
| to_chat(src, examine_block("<span class='infoplain'>[result.Join()]</span>")) | |
| to_chat(src, examine_block(span_info(result.Join("\n"))) |
Comment on lines
+18
to
+25
| /obj/item/weaponcrafting/receiver/create_slapcraft_component() | ||
| var/static/list/slapcraft_recipe_list = list(/datum/crafting_recipe/piperifle) | ||
|
|
||
| AddElement( | ||
| /datum/element/slapcrafting,\ | ||
| slapcraft_recipes = slapcraft_recipe_list,\ | ||
| ) | ||
|
|
There was a problem hiding this comment.
Suggested change
| /obj/item/weaponcrafting/receiver/create_slapcraft_component() | |
| var/static/list/slapcraft_recipe_list = list(/datum/crafting_recipe/piperifle) | |
| AddElement( | |
| /datum/element/slapcrafting,\ | |
| slapcraft_recipes = slapcraft_recipe_list,\ | |
| ) | |
| /obj/item/weaponcrafting/receiver/Initialize(mapload) | |
| . = ..() | |
| var/static/list/slapcraft_recipe_list = list(/datum/crafting_recipe/piperifle) | |
| AddElement( | |
| /datum/element/slapcrafting,\ | |
| slapcraft_recipes = slapcraft_recipe_list,\ | |
| ) | |
Comment on lines
+34
to
+40
| /obj/item/weaponcrafting/stock/create_slapcraft_component() | ||
| var/static/list/slapcraft_recipe_list = list(/datum/crafting_recipe/smoothbore_disabler, /datum/crafting_recipe/laser_musket) | ||
|
|
||
| AddElement( | ||
| /datum/element/slapcrafting,\ | ||
| slapcraft_recipes = slapcraft_recipe_list,\ | ||
| ) |
There was a problem hiding this comment.
Suggested change
| /obj/item/weaponcrafting/stock/create_slapcraft_component() | |
| var/static/list/slapcraft_recipe_list = list(/datum/crafting_recipe/smoothbore_disabler, /datum/crafting_recipe/laser_musket) | |
| AddElement( | |
| /datum/element/slapcrafting,\ | |
| slapcraft_recipes = slapcraft_recipe_list,\ | |
| ) | |
| /obj/item/weaponcrafting/stock/Initialize(mapload) | |
| . = ..() | |
| var/static/list/slapcraft_recipe_list = list(/datum/crafting_recipe/smoothbore_disabler, /datum/crafting_recipe/laser_musket) | |
| AddElement( | |
| /datum/element/slapcrafting,\ | |
| slapcraft_recipes = slapcraft_recipe_list,\ | |
| ) |
| ) | ||
| category = CAT_EQUIPMENT | ||
|
|
||
| /datum/crafting_recipe/scienceglassesremoval |
There was a problem hiding this comment.
Kind of a confusing typepath name.
Suggested change
| /datum/crafting_recipe/scienceglassesremoval | |
| /datum/crafting_recipe/science_sunglasses |
Comment on lines
+304
to
+306
| add_glasses_slapcraft_component() | ||
|
|
||
| /obj/item/clothing/glasses/sunglasses/advanced/proc/add_glasses_slapcraft_component() |
There was a problem hiding this comment.
Suggested change
| add_glasses_slapcraft_component() | |
| /obj/item/clothing/glasses/sunglasses/advanced/proc/add_glasses_slapcraft_component() |
| desc = "A pair of tacky purple sunglasses that allow the wearer to recognize various chemical compounds with only a glance." | ||
| clothing_flags = SCAN_REAGENTS | ||
|
|
||
| /obj/item/clothing/glasses/sunglasses/advanced/chemical/add_glasses_slapcraft_component() |
There was a problem hiding this comment.
Suggested change
| /obj/item/clothing/glasses/sunglasses/advanced/chemical/add_glasses_slapcraft_component() | |
| /obj/item/clothing/glasses/sunglasses/advanced/chemical/Initialize(mapload) | |
| . = ..() |
|
slapcrafting is superior to menus in every conceivable way honestly. the only disadvantage is not knowing all the recipes but i genuinely believe that learning them is an integral part of the ss13 experience |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This adds a component that lets a player craft without the use of the crafting menu interface.
A set number of objects have the component attached(pipes for pipeweapons, bones for bonearmor) and when the user applies a constituent part that is in the recipe list with that object, it will queue the user to complete that recipe.
If there is more than one it will show however many items in the radial.
Ports:
Why It's Good For The Game
It was requested.
Less reliance on the crafting menu
Testing Photographs and Procedure
Screenshots&Videos
dreamseeker_tDPdjIMtqC.mp4
Changelog
🆑 rkz, carlarctg
add: adds slapcrafting
add: adds sci sunglasses
fix: fixes examine_more
tweak: removed silkstring. All recipes that used it (2) use normal string now.
/:cl: