Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some White Balance and add Russian Tranlation #7049

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

Iliya5digital
Copy link

No description provided.

@Lawrence37
Copy link
Collaborator

Thanks for the translations @Iliya5digital!

Regarding the white balance profiles, I don't think they should be bundled with RawTherapee. They are quite specific, affecting only the color temperature. There are alternatives to quickly setting the color temperature in most cases. For niche applications, users can add profiles to their own installations.

@Lawrence37 Lawrence37 added the scope: localization Translation label Apr 20, 2024
@Lawrence37 Lawrence37 added this to the v5.11 milestone Apr 20, 2024
@Lawrence37
Copy link
Collaborator

@Iliya5digital Could you please create separate pull requests for the translation and white balance additions? Also, I think the profiles are unnecessary (they also need some trimming because they total almost 25k lines), especially as the WB presets are in the WB tool.

@Iliya5digital
Copy link
Author

how do I make separate separate pull requests for the translation and white balance additions?

@Lawrence37
Copy link
Collaborator

You need to separate your changes into different branches, then open a pull request for each branch.

Lawrence37 added a commit to Lawrence37/RawTherapee that referenced this pull request Jul 21, 2024
Translation supplied by Iliya5digital in
Beep6581#7049.
@Lawrence37 Lawrence37 modified the milestones: v5.11, v6.0 Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants