Added flanged bearings #1316
Merged
Added flanged bearings #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it should be an error to specify flange dimensions if flange==false? |
|
Also I think we need some additional examples that show flanges and shields. |
added 2 commits
November 28, 2023 07:54
…added more unshielded flanged bearing trade sizes
|
I've added a few more examples and some more common sizes for flanged + unshielded bearings. I've not done much error handling in OpenSCAD before, so not sure I've landed on the best approach, LMK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for flanged bearings, and adds a number of standard flanged bearing trade sizes.