Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvements: spelling, grammar, examples #1544

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amatulic
Copy link
Contributor

@amatulic amatulic commented Jan 18, 2025

vnf.scad - minor wordmsithing of documentation, added missing 3D parameter to examples that weren't generating images.

comparisons.scad - minor wordsmithing, spelling and grammar improvments, including the two typos in #1543, which can be closed after this PR is merged.

No code has been changed, just the comments.

@amatulic
Copy link
Contributor Author

@revarbat - please review and merge. Besides typo corrections and slight wordsmithing in comments, the main effect of this PR is to restore the missing examples in vnf.scad because they were prefaced by Example: instead of Example(3D). I had to correct some code in the examples because sphere() no longer has a style parameter. That's now in spheroid(). This PR also closes #1543.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant