Change $slop docs and tester #1699
Open
+54
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporating findings from Issue BelfrySCAD#1679 Describing why based on the diff on my screen, starting top to bottom: Removing XY vs Z axis, because the printing direction isn't known for the parts. Even precise CNC machining still has tolerances and I tried to write a simple way of passing that along. Adding the limitations we talked about in issue BelfrySCAD#1679. Added some more written examples of where slop should be added. Now that I'm writing this, these would be better as an example. I can't add a new line to the first "Calibration" line because that'll make a new number. I thought this was good info to add though. Moved caveat to Limitations section. Added line about filleting/chamfers now that I made the tester cut off corners, so you can test both ways. Also fix a typo later in doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating findings from Issue #1679
Describing why based on the diff on my screen, starting top to bottom:
Removing XY vs Z axis, because the printing direction isn't known for the parts. Even precise CNC machining still has tolerances and I tried to write a simple way of passing that along.
Adding the limitations we talked about in issue #1679.
Added some more written examples of where slop should be added. Now that I'm writing this, these would be better as an example.
I can't add a new line to the first "Calibration" line because that'll make a new number. I thought this was good info to add though.
Moved caveat to Limitations section.
Added line about filleting/chamfers now that I made the tester cut off corners, so you can test both ways.
Also fix a typo later in doc