Change threading and screws to use 2*$slop #1700
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [my argument](BelfrySCAD#1679 (comment)), I believe this is the proper method. There is only one mating surface for each radius, so by following the documentation for `$slop`, we should only be adding one `$slop` for radius and not two.
|
One slop per radius is for TIGHT fits, which fails to let a screw screw/unscrew at larger radiuses, and I imagine will fail to let you insert the screw at all, and/or break the screw at low radiuses. |
That's why screws.scad has a tolerance system using ISO standards for making working screw threads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my argument, I believe this is the proper method. There is only one mating surface for each radius, so by following the documentation for
$slop, we should only be adding one$slopfor radius and not two.This is backward-incompatible.