Skip to content

xcyl(), ycyl(), zcyl() pass through all parameters to cyl() #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amatulic
Copy link
Contributor

@amatulic amatulic commented Jul 7, 2025

Changes to xcyl(), ycyl(), and zcyl() in shapes3d.scad:

  • Now xcyl(), ycyl(), and zcyl() can have textures like cyl(). All three modules now take all the same arguments as cyl() except for orient.
  • For compatibility with how these modules worked previously, orient is used to orient the cylinder.
  • All three modules now have function counterparts, like cyl().
  • Documentation shortened, now explains that these are alias shortcuts for cyl() and refers the reader to the cyl() documentation for usage.

The cuboid() module calls xcyl(), ycyl(), and zcyl(). Tested all examples in cuboid() as well as the original examples in xcyl(), ycyl(), and zcyl().

@amatulic
Copy link
Contributor Author

amatulic commented Jul 8, 2025

All pass-through arguments are now named, for robustness in case the arg list for cyl() ever changes.

Also, the original function version of cyl() had width and height in two different places in the argument list. Fixed.

Re-tested examples in cuboid(), xcyl(), ycycl(), and zcyl(), as well as examples in cyl().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant