Fix trigonometry alias problem#1891
Merged
adrianVmariano merged 20 commits intoBelfrySCAD:masterfrom Jan 30, 2026
Merged
Conversation
RAMilewski
changed the title
Add new entries to See Also lines.
Collaborator
|
Maybe opp_hyp_to_adj the synopsis should flip order to match The terms "primary angle" and "primary corner" appear throughout. There were there before, so not your fault....but I've never heard them and neither has the Claude AI, or google. So maybe not a term to use...or not without definition, at least. (And "primary" suggests biggest, maybe, which isn't right.) Maybe "reference angle"? I came up with that on my own, but Claude also suggested it. Instead of: maybe just in all the places where it appears? ang_adj_to_opp() That's all I noticed. |
replace primary angle and primary corner with reference angle.
Fix missed reference angle changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved former "aliases" to full function entries.
Resolves #1805