Skip to content

Conversation

@ponderingdemocritus
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
eternum Ignored Ignored Preview Sep 24, 2025 0:19am
eternum-docs Ignored Ignored Preview Sep 24, 2025 0:19am
eternum-landing Ignored Ignored Preview Sep 24, 2025 0:19am
eternum-mobile Ignored Ignored Preview Sep 24, 2025 0:19am

@ponderingdemocritus ponderingdemocritus changed the base branch from next to blitz September 24, 2025 00:18
@chatgpt-codex-connector
Copy link

Codex Review: Here are some suggestions.

const connectWallet = async () => {
try {
console.log("Attempting to connect wallet...");
connect({ connector: env.VITE_PUBLIC_CHAIN === "local" ? connectors[0] : (connectors[0] as any).controller });
console.log("Wallet connected successfully.");

[P1] Await wallet connect promise before reporting success

The new wallet hook drops the await around connect(...). Without awaiting the promise, the success log runs before the connector has actually finished, and any rejection occurs outside the surrounding try/catch, so callers that rely on connectWallet resolving or throwing to route the user will no longer behave correctly when the connection fails. Restoring await connect(...) keeps the function asynchronous and preserves error handling.


Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants