Even further with Tag... #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Sources/SwiftSgml/TagBuilder.swift
|
Not sure if you started working on the merge yet. But I added a few more things. Like handling the "lang" attribute |
Other Global Attributes... add nil values and conditions
Conflicts: Sources/SwiftHtml/Attributes/Events.swift Sources/SwiftHtml/Tags/Body.swift Sources/SwiftHtml/Tags/Head.swift Sources/SwiftHtml/Tags/Html.swift Sources/SwiftSgml/Tag.swift Tests/SwiftHtmlTests/SwiftHtmlTests.swift
|
Is there any update on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes further than my previous one with changes to
TagAnd I'll admit it may be a bridge too far. Not sure. But I thought I'd put it out there.
It tries to address some things that have always struck me as odd or confusing about the library...
•
Tagappears like the base class. And thenGroupTagis a derivation. But it should really be the other way around.GroupTagis more foundational. It's just a renderless collection of childTags. Every other kind ofTagis a specialization: name, attributes and even more children. So this PR eliminatesGroupTagand makesTagrenderless by default. And then provides options and subclasses to specialize.TagBuilderjust puts components inside anotherTag.•
Nodehas always confused me. And why its properties should be separate. Maybe there's a good reason, but I don't see it in the library. So I moved them all intoTag. And I think it makes how to use the class more apparent. I also eliminated.groupand made thetypeproperty onTagoptional. Because that's essentially what the class is... a nothing, invisible container.• Lots of empty arrays get allocated.
Tag.childrenandNode.attributesare[]by default. And while it might not seem like a lot memory allocation, I wonder if it adds up in large hierarchies. So I made them optional.