Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bioDBnet REST API support #29

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

thatRichman
Copy link

@thatRichman thatRichman commented Oct 17, 2019

Module to implement bioDBnet REST API access

Types of changes

This PR implements the following changes:

  • ✨ New feature (A non-breaking change which adds functionality).
  • 🐛 Bug fix (A non-breaking change, which fixes an issue).
  • 💥 Breaking change (fix or feature that would cause existing functionality to change).

📋 Additional detail

bioDBnet, created and maintained by the Advanced Biomedical Computing Center (ABCC), Frederick National Laboratory for Cancer Research (FNLCR), and
National Cancer Institute at Frederick (NCI), is a useful tool for mapping identifiers from various biological, chemical, and pharmacological databases to identifiers in other databases.

I have implemented this module following style and functionality precedence from eutils.jl, as I wished to help maintain consistency between modules as much as possible.

This will be my first contribution to any public project, so I apologize for anything that has been done incorrectly.

☑️ Checklist

  • 🎨 The changes implemented is consistent with the julia style guide.
  • 📘 I have updated and added relevant docstrings, in a manner consistent with the documentation styleguide.
  • 📘 I have added or updated relevant user and developer manuals/documentation in docs/src/.
  • 🆗 There are unit tests that cover the code changes I have made.
  • 🆗 The unit tests cover my code changes AND they pass.
  • 📝 I have added an entry to the [UNRELEASED] section of the manually curated CHANGELOG.md file for this repository.
  • 🆗 All changes should be compatible with the latest stable version of Julia.
  • 💭 I have commented liberally for any complex pieces of internal code.

@thatRichman thatRichman changed the title Feature/biodbnet add bioDBnet REST API support Oct 17, 2019
@kescobo
Copy link
Member

kescobo commented Oct 18, 2019

This will be my first contribution to any public project, so I apologize for anything that has been done incorrectly.

Woo! Welcome to open source :-)

This is a very welcome contribution, but alas I'm not competent to review it.

@kescobo
Copy link
Member

kescobo commented Apr 7, 2021

@thatRichman - really sorry that this has languished for so long, especially seeing as how it's your first contribution :-(. Seems from your github activity that it didn't slow you down though - I'm glad for that. This package has not been super actively maintained, but I hope to turn that around. Are you willing to rebase this off the current master brach, then I can take a look?

If you're not sure how to rebase, I can help with that.

@kescobo kescobo self-requested a review April 7, 2021 14:10
@thatRichman
Copy link
Author

@thatRichman - really sorry that this has languished for so long, especially seeing as how it's your first contribution :-(. Seems from your github activity that it didn't slow you down though - I'm glad for that. This package has not been super actively maintained, but I hope to turn that around. Are you willing to rebase this off the current master brach, then I can take a look?

If you're not sure how to rebase, I can help with that.

No worries at all! I've been plenty busy so I almost completely forgot about this. I'll make sure that it hasn't broken over the past year and rebase.

@kescobo
Copy link
Member

kescobo commented Apr 8, 2021

Fantastic! Ping me when it's done and I'll give it a review

@thatRichman
Copy link
Author

I've confirmed everything still works and I think (hope) I rebased correctly! Happy to fix anything that may have been done incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants