-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bioDBnet REST API support #29
base: master
Are you sure you want to change the base?
Conversation
bug fixes for bioDBnet.jl
…ices.jl into feature/bioDBnet
Woo! Welcome to open source :-) This is a very welcome contribution, but alas I'm not competent to review it. |
@thatRichman - really sorry that this has languished for so long, especially seeing as how it's your first contribution :-(. Seems from your github activity that it didn't slow you down though - I'm glad for that. This package has not been super actively maintained, but I hope to turn that around. Are you willing to rebase this off the current master brach, then I can take a look? If you're not sure how to rebase, I can help with that. |
No worries at all! I've been plenty busy so I almost completely forgot about this. I'll make sure that it hasn't broken over the past year and rebase. |
Fantastic! Ping me when it's done and I'll give it a review |
I've confirmed everything still works and I think (hope) I rebased correctly! Happy to fix anything that may have been done incorrectly. |
Module to implement bioDBnet REST API access
Types of changes
This PR implements the following changes:
📋 Additional detail
bioDBnet, created and maintained by the Advanced Biomedical Computing Center (ABCC), Frederick National Laboratory for Cancer Research (FNLCR), and
National Cancer Institute at Frederick (NCI), is a useful tool for mapping identifiers from various biological, chemical, and pharmacological databases to identifiers in other databases.
I have implemented this module following style and functionality precedence from eutils.jl, as I wished to help maintain consistency between modules as much as possible.
This will be my first contribution to any public project, so I apologize for anything that has been done incorrectly.
☑️ Checklist
docs/src/
.[UNRELEASED]
section of the manually curatedCHANGELOG.md
file for this repository.