Skip to content

closes #1955 #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

closes #1955 #1956

merged 1 commit into from
Jun 30, 2025

Conversation

tandem97
Copy link
Contributor

closes #1955

@tandem97 tandem97 requested a review from a team as a code owner May 30, 2025 21:26
@moloch-- moloch-- requested a review from Copilot June 8, 2025 06:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR closes issue #1955 by modifying the process enumeration to request full process details on Windows.

  • Changes ps.Processes call from minimal to full information retrieval.
Comments suppressed due to low confidence (2)

implant/sliver/priv/priv_windows.go:215

  • The comment no longer matches the code change; update it to reflect that full process details are now being retrieved or adjust the code to align with the existing comment.
// We do not need full process info here, just PID and executable name

implant/sliver/priv/priv_windows.go:218

  • Calling ps.Processes(true) loads full process information which may incur unnecessary overhead if only PID and name are needed; consider reverting to false or ensuring the extra data is required for downstream logic.
p, err := ps.Processes(true)

@moloch-- moloch-- merged commit 9939d2c into BishopFox:master Jun 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible error in the code
2 participants