refactor(sdk-coin-trx): migrate mocha and sinon to node:test #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachushaji
reviewed
Feb 7, 2025
| import { getBuilder } from '../../src/lib/builder'; | ||
|
|
||
| describe('Coin factory', () => { | ||
| it('should instantiate TRX builder properly', () => { | ||
| const trxBuilder = getBuilder('trx'); | ||
| should.exist(trxBuilder); | ||
| assert.notEqual(trxBuilder, undefined); |
There was a problem hiding this comment.
think you should use assert.ok for this https://nodejs.org/api/assert.html#assertokvalue-message
kev-daniell
force-pushed
the
DX-955-sandbox-sdk-coin-trx-module
branch
from
0914adb to
56cfa00
Compare
sachushaji
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DX-955
sinon migration was done using this script
mocha migration was done using this script