Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-coin-sol): use contractAddress to form tokenAddress #5541

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

rakeshgsharma
Copy link
Contributor

@rakeshgsharma rakeshgsharma commented Feb 13, 2025

Description

Use contractAddress to form tokenAddress for SOL

Issue Number

WIN-4560

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test case added

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rakeshgsharma rakeshgsharma changed the title chore(sdk-coin-sol): use contractAddress to form contractName chore(sdk-coin-sol): use contractAddress to form tokenAddress Feb 13, 2025
@rakeshgsharma rakeshgsharma force-pushed the WIN-4540-alter-tokenAddress-for-sol branch 4 times, most recently from 05762ae to 09ddade Compare February 13, 2025 11:15
@rakeshgsharma rakeshgsharma marked this pull request as ready for review February 13, 2025 11:54
@rakeshgsharma rakeshgsharma requested review from a team as code owners February 13, 2025 11:54
Comment on lines 28 to 29
solTokenCoin.tokenAddress.should.equal('J3NKxxXZcnNiMjKw9hYb2K4LUxgwB6t1FtPtQVsv3KFr');
solTokenCoin.tokenAddress.should.equal('J3NKxxXZcnNiMjKw9hYb2K4LUxgwB6t1FtPtQVsv3KFr');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
solTokenCoin.tokenAddress.should.equal('J3NKxxXZcnNiMjKw9hYb2K4LUxgwB6t1FtPtQVsv3KFr');
solTokenCoin.tokenAddress.should.equal('J3NKxxXZcnNiMjKw9hYb2K4LUxgwB6t1FtPtQVsv3KFr');
solTokenCoin.tokenAddress.should.equal('J3NKxxXZcnNiMjKw9hYb2K4LUxgwB6t1FtPtQVsv3KFr');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rakeshgsharma rakeshgsharma force-pushed the WIN-4540-alter-tokenAddress-for-sol branch from 09ddade to e2db18c Compare February 17, 2025 04:59
@rakeshgsharma rakeshgsharma merged commit cc37428 into master Feb 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants