Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-coin-algo): remove tokenurl from coin statics #5546

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

rakeshgsharma
Copy link
Contributor

TICKET: WIN-4544

Description

Removing tokenURL from coin statics, as its not used in any downstream consumers.

Issue Number

WIN-4544

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No tests needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rakeshgsharma rakeshgsharma marked this pull request as ready for review February 13, 2025 13:32
@rakeshgsharma rakeshgsharma requested review from a team as code owners February 13, 2025 13:32
Copy link
Contributor

@sachushaji sachushaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, can you mention the breaking change within the commit

@rakeshgsharma rakeshgsharma force-pushed the WIN-4544-remove-tokenurl-for-algo branch from 669a911 to eb1231a Compare February 17, 2025 04:57
TICKET: WIN-4544
BREAKING CHANGE: tokenurl is removed from coin statics
@rakeshgsharma rakeshgsharma force-pushed the WIN-4544-remove-tokenurl-for-algo branch from eb1231a to 2e5c7aa Compare February 17, 2025 05:20
@rakeshgsharma rakeshgsharma merged commit eceb874 into master Feb 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants